Differential D6284

The -Wredundant-move warning is C++ only
ClosedPublic
Actions

Authored by Fabien on May 28 2020, 19:45.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC06234fb46320: The -Wredundant-move warning is C++ only

Summary

Prevent the compiler message:

warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++
but not for C

Test Plan

ninja check

Check the message is gone.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 28 2020, 19:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 19:45

Fabien requested review of this revision.May 28 2020, 19:46

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

majcosta accepted this revision.May 28 2020, 19:49

This revision is now accepted and ready to land.May 28 2020, 19:49

Harbormaster completed remote builds in B11072: Diff 20681.May 28 2020, 19:55

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Closed by commit rABC06234fb46320: The -Wredundant-move warning is C++ only (authored by Fabien). · Explain WhyMay 29 2020, 07:39

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC06234fb46320: The -Wredundant-move warning is C++ only.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

2 lines

Diff 20693

View Options

The -Wredundant-move warning is C++ onlyClosedPublicActions