Page MenuHomePhabricator
Differential D6285

Disable some more leveldb warnings
ClosedPublic
Actions

Authored by Fabien on May 28 2020, 20:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC064404306ceb: Disable some more leveldb warnings
Summary

This frees the output from the leveldb warnings.
There is a single -Wmaybe-initialized outside of the tests and it is
relying on the GCC __get_cpuid() function to assign a value to a
pointer, which should be safe.

Test Plan

With both GCC and Clang:

ninja all check-leveldb

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 28 2020, 20:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 20:09
Fabien requested review of this revision.May 28 2020, 20:09
teamcity added a comment.May 28 2020, 20:09

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 28 2020, 20:09

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 28 2020, 20:09

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 28 2020, 20:10

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 28 2020, 20:12

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 28 2020, 20:18

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11073: Diff 20682.May 28 2020, 20:18
deadalnix accepted this revision.May 28 2020, 20:31
This revision is now accepted and ready to land.May 28 2020, 20:31
Closed by commit rABC064404306ceb: Disable some more leveldb warnings (authored by Fabien). · Explain WhyMay 29 2020, 07:39
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC064404306ceb: Disable some more leveldb warnings.

Revision Contents
Changeset List

PathSize
src/
leveldb/
9 lines

Diff 20694

View Options

src/leveldb/CMakeLists.txt

Loading...