Page MenuHomePhabricator
Differential D6305

[backport#14802] rpc: faster getblockstats using BlockUndo data
ClosedPublic
Actions

Authored by majcosta on May 31 2020, 04:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe5537143445b: [backport#14802] rpc: faster getblockstats using BlockUndo data
Summary

Using undo data for a block (rev?????.dat) we can retrieve value information about prevouts and calculate the final transaction fee (rate). This approach is about 80x faster, drops the requirement for -txindex, and works for all non-pruned blocks.

https://github.com/bitcoin/bitcoin/pull/14802/commits/d20d7567528e216badb8475df298bb3cec008985

Depends on D6304

Backport of Core PR14802

Test Plan
ninja
./test/functional/test_runner.py rpc_getblockstats --gen-test-data
ninja check-all

run bitcoin-cli getblockstats non-pruned-block-height on a node without -txindex now works

Diff Detail

Event Timeline

majcosta created this revision.May 31 2020, 04:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2020, 04:45
majcosta requested review of this revision.May 31 2020, 04:45
teamcity added a comment.May 31 2020, 04:46

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 31 2020, 04:46

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 31 2020, 04:46

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 31 2020, 04:47

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

majcosta edited the summary of this revision. (Show Details)May 31 2020, 04:47
majcosta edited the test plan for this revision. (Show Details)
majcosta added a parent revision: D6304: [backport#15623] refactor: Expose UndoReadFromDisk in header.
teamcity added a comment.May 31 2020, 04:49

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 31 2020, 04:56

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11106: Diff 20734.May 31 2020, 04:56
deadalnix requested changes to this revision.May 31 2020, 21:59
deadalnix added a subscriber: deadalnix.

What the deal with test/functional/data/rpc_getblockstats.json ?

This revision now requires changes to proceed.May 31 2020, 21:59
majcosta updated this revision to Diff 20754.Jun 1 2020, 14:46
majcosta edited the summary of this revision. (Show Details)

that was an oversight on my part, I did not see that core generated new test data.

teamcity added a comment.Jun 1 2020, 14:47

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 1 2020, 14:47

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.Jun 1 2020, 14:47

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

majcosta edited the test plan for this revision. (Show Details)Jun 1 2020, 14:48
majcosta edited the test plan for this revision. (Show Details)
teamcity added a comment.Jun 1 2020, 14:50

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.Jun 1 2020, 14:51

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.Jun 1 2020, 15:00

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11116: Diff 20754.Jun 1 2020, 15:00
deadalnix accepted this revision.Jun 1 2020, 22:00
This revision is now accepted and ready to land.Jun 1 2020, 22:00
Closed by commit rABCe5537143445b: [backport#14802] rpc: faster getblockstats using BlockUndo data (authored by Felix Weis <mail@felixweis.com>, committed by majcosta). · Explain WhyJun 2 2020, 09:47
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCe5537143445b: [backport#14802] rpc: faster getblockstats using BlockUndo data.

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
rpc/
45 lines
test/
functional/
58 lines

Diff 20734

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

test/functional/rpc_getblockstats.py

Loading...