Page MenuHomePhabricator
Differential D6313

[CMAKE] Rename secp256k1 test targets
ClosedPublic
Actions

Authored by Fabien on Jun 1 2020, 14:50.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCb2531ebe4c9c: [CMAKE] Rename secp256k1 test targets
Summary

Running the secp256k1 tests is obvious, using a check-secp256k1-*
target. But building the target without running the tests is much more
complicated, since names like tests doesn't tell much.
This diff renames the targets to prefix with secp256k1-* just like we
do with bitcoin-*.

Test Plan
ninja secp256k1-tests
ninja secp256k1-exhaustive_tests
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 1 2020, 14:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 1 2020, 14:50
Fabien requested review of this revision.Jun 1 2020, 14:50
teamcity added a comment.Jun 1 2020, 14:51

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.Jun 1 2020, 14:51

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.Jun 1 2020, 14:51

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 1 2020, 14:53

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.Jun 1 2020, 14:56

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Fabien added a child revision: D6315: [CI] Enable -Werror where possible.Jun 1 2020, 15:00
teamcity added a comment.Jun 1 2020, 15:04

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11117: Diff 20755.Jun 1 2020, 15:04
jasonbcox accepted this revision.Jun 1 2020, 16:20
This revision is now accepted and ready to land.Jun 1 2020, 16:20
Closed by commit rABCb2531ebe4c9c: [CMAKE] Rename secp256k1 test targets (authored by Fabien). · Explain WhyJun 2 2020, 08:30
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb2531ebe4c9c: [CMAKE] Rename secp256k1 test targets.
Fabien removed a child revision: D6315: [CI] Enable -Werror where possible.Jun 2 2020, 11:51

Revision Contents
Changeset List

PathSize
src/
secp256k1/
8 lines

Diff 20778

View Options

src/secp256k1/CMakeLists.txt

Loading...