The latest version is expected to give the best warnings.
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABC45880ccf379c: [CI] Install Clang 10 and use it for the werror build
Run the CI build-werror build plan.
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
contrib/teamcity/setup-debian-buster.sh | ||
---|---|---|
99 ↗ | (On Diff #20756) | What's the benefit to adding clang-10 to alternatives when it's only use calls it explicitly? |
This approach is not the right one. We want to have -Werror enabled on regular builds that supports it.
@deadalnix OK but I think you comment applies to D6315. -Werror can be set for regular builds, and we can turn the current build-werror into a clang 10 build to prevent introducing warnings from the latest versions. I will update D6315 to reflect that.
contrib/teamcity/setup-debian-buster.sh | ||
---|---|---|
99 ↗ | (On Diff #20756) | At some point it will make it easier to use clang 10 as a default. I would have set the alternative rather than calling the version explicitly but it is persistent, and will have change the later builds. |
The same comment applies more or less. If we are using clang 10 then we are using clang 10. The existence of a specific werror build is dubbious.