[CMAKE] Fix a -Wpointer-to-int-cast when searching Jemalloc
ClosedPublic
Actions

Authored by Fabien on Jun 3 2020, 15:56.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCc9df2beb473f: [CMAKE] Fix a -Wpointer-to-int-cast when searching Jemalloc

Summary

This would trigger failures when -Werror is enabled, such as:
https://build.bitcoinabc.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=66573&guest=1#footer

Test Plan

cmake -GNinja .. \
  -DUSE_JEMALLOC_EXPERIMENTAL=ON \
  -DCMAKE_C_FLAGS=-Werror

This will fail before this patch and succeed after.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_warning_cast_ptr_to_int_CheckJemallocBuilds

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11162
Build 20902: Default Diff Build & Tests
Build 20901: Build without Wallet
Build 20900: Build with clang-10
Build 20899: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 3 2020, 15:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2020, 15:56

Fabien requested review of this revision.Jun 3 2020, 15:56

Harbormaster completed remote builds in B11162: Diff 20832.Jun 3 2020, 16:09

deadalnix accepted this revision.Jun 3 2020, 16:45

This revision is now accepted and ready to land.Jun 3 2020, 16:45

Closed by commit rABCc9df2beb473f: [CMAKE] Fix a -Wpointer-to-int-cast when searching Jemalloc (authored by Fabien). · Explain WhyJun 3 2020, 19:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc9df2beb473f: [CMAKE] Fix a -Wpointer-to-int-cast when searching Jemalloc.

Revision Contents
Changeset List

Path

Size

cmake/

utils/

CheckJemallocBuilds.c

3 lines

Diff 20832

View Options

cmake/utils/CheckJemallocBuilds.c

[CMAKE] Fix a -Wpointer-to-int-cast when searching JemallocClosedPublicActions