Page MenuHomePhabricator
Differential D6350

[backport#15777] [docs] Add doxygen comment for CKeyPool
ClosedPublic
Actions

Authored by majcosta on Jun 3 2020, 19:23.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rABC8a2ed5f2d0de: [backport#15777] [docs] Add doxygen comment for CKeyPool
Summary

[docs] Add doxygen comment for CReserveKey

https://github.com/bitcoin/bitcoin/pull/15777/commits/37796b2dd49772b17ff39a1a71b73f6d2248ac6d
https://github.com/bitcoin/bitcoin/pull/15777/commits/f1a77b0c5176306ca9f6f30211e32d3502ed4281

Concludes backport of Core PR15777

Test Plan
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 3 2020, 19:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2020, 19:23
majcosta requested review of this revision.Jun 3 2020, 19:23
teamcity edited the summary of this revision. (Show Details)Jun 3 2020, 19:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11169: Diff 20843.Jun 3 2020, 19:34
jasonbcox requested changes to this revision.Jun 3 2020, 20:48
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/wallet.h
159 ↗(On Diff #20843)

Core -> ABC

267 ↗(On Diff #20843)

Just FYI this is out of order with PR15748

This revision now requires changes to proceed.Jun 3 2020, 20:48
majcosta added inline comments.Jun 3 2020, 20:53
src/wallet/wallet.h
267 ↗(On Diff #20843)

nice catch, thank you

majcosta updated this revision to Diff 20866.Jun 4 2020, 01:03

fixed comment

Harbormaster completed remote builds in B11184: Diff 20866.Jun 4 2020, 01:21
deadalnix accepted this revision.Jun 4 2020, 09:58
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/wallet.h
153 ↗(On Diff #20866)

line break after **

252 ↗(On Diff #20866)

line break after **

jasonbcox accepted this revision.Jun 4 2020, 18:04
This revision is now accepted and ready to land.Jun 4 2020, 18:04
Closed by commit rABC8a2ed5f2d0de: [backport#15777] [docs] Add doxygen comment for CKeyPool (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyJun 4 2020, 19:44
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC8a2ed5f2d0de: [backport#15777] [docs] Add doxygen comment for CKeyPool.

Revision Contents
Changeset List

PathSize
src/
wallet/
85 lines

Diff 20912

View Options

src/wallet/wallet.h

Loading...