Differential D6367

[refactor] add const CCoinControl& param to SendMoney
ClosedPublic
Actions

Authored by majcosta on Jun 4 2020, 14:47.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC7d44fb717d3c: [refactor] add const CCoinControl& param to SendMoney

Summary

this was cleaned up in a previous diff but is now a hurdle to
backporting PR13756. this change makes the backport possible and brings
us a tad closer to core for less merge conflicts down the road.

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 4 2020, 14:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2020, 14:47

majcosta requested review of this revision.Jun 4 2020, 14:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11199: Diff 20890.Jun 4 2020, 14:56

deadalnix accepted this revision.Jun 4 2020, 17:56

This revision is now accepted and ready to land.Jun 4 2020, 17:56

Closed by commit rABC7d44fb717d3c: [refactor] add const CCoinControl& param to SendMoney (authored by majcosta). · Explain WhyJun 4 2020, 19:45

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC7d44fb717d3c: [refactor] add const CCoinControl& param to SendMoney.

jasonbcox mentioned this in D7792: Fix passing of coin control in SendMoney().Oct 7 2020, 00:14

jasonbcox mentioned this in rABC2fef637bd376: Fix passing of coin control in SendMoney().Oct 7 2020, 01:18

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

8 lines

Diff 20913

View Options

[refactor] add const CCoinControl& param to SendMoneyClosedPublicActions