Page MenuHomePhabricator
Differential D6376

util: refactor upper/lowercase functions
ClosedPublic
Actions

Authored by deadalnix on Jun 4 2020, 21:34.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCfeb9dc577c7e: util: refactor upper/lowercase functions
Summary

This includes renaming Downcase() to ToLower() and make it return a string rather than modify referenced arg.
Also adds ToUpper() string version.

This is a backport of Core PR16566

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 4 2020, 21:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2020, 21:34
deadalnix requested review of this revision.Jun 4 2020, 21:34
teamcity edited the summary of this revision. (Show Details)Jun 4 2020, 21:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D6377: util: Add Join helper to join a list of strings.Jun 4 2020, 21:44
Harbormaster completed remote builds in B11215: Diff 20923.Jun 4 2020, 21:53
jasonbcox accepted this revision.Jun 4 2020, 23:02
This revision is now accepted and ready to land.Jun 4 2020, 23:02
Closed by commit rABCfeb9dc577c7e: util: refactor upper/lowercase functions (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by deadalnix). · Explain WhyJun 4 2020, 23:10
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCfeb9dc577c7e: util: refactor upper/lowercase functions.

Revision Contents
Changeset List

PathSize
src/
2 lines
4 lines
test/
18 lines
util/
33 lines
16 lines
2 lines

Diff 20927

View Options

src/netbase.h

Loading...
View Options

src/netbase.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...
View Options

src/util/system.cpp

Loading...