Page MenuHomePhabricator
Differential D6380

Add remaining linter dependencies to CI base image
ClosedPublic
Actions

Authored by jasonbcox on Jun 4 2020, 23:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC554d897104b2: Add remaining linter dependencies to CI base image
Summary

Needed for the land bot. See associated failure during one of the dry-runs: https://build.bitcoinabc.org/viewLog.html?buildId=69159&tab=buildLog&_focus=189#_state=70

Test Plan

Pull the base image and verify shellcheck and php-codesniffer are installed

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 4 2020, 23:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2020, 23:14
jasonbcox requested review of this revision.Jun 4 2020, 23:14
Harbormaster completed remote builds in B11219: Diff 20930.Jun 4 2020, 23:39
Fabien requested changes to this revision.Jun 5 2020, 07:46
Fabien added a subscriber: Fabien.

You'll better install all the missing linters at once

This revision now requires changes to proceed.Jun 5 2020, 07:46
jasonbcox updated this revision to Diff 20951.Jun 5 2020, 18:43

Add missing php-codesniffer

Harbormaster completed remote builds in B11230: Diff 20951.Jun 5 2020, 19:05
Fabien accepted this revision.Jun 5 2020, 19:16
This revision is now accepted and ready to land.Jun 5 2020, 19:16
jasonbcox retitled this revision from Add shellcheck to CI base image to Add remaining linter dependencies to CI base image.Jun 5 2020, 20:30
jasonbcox edited the test plan for this revision. (Show Details)
Closed by commit rABC554d897104b2: Add remaining linter dependencies to CI base image (authored by jasonbcox). · Explain WhyJun 5 2020, 20:37
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC554d897104b2: Add remaining linter dependencies to CI base image.

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
2 lines

Diff 20961

View Options

contrib/teamcity/setup-debian-buster.sh

Loading...