Page MenuHomePhabricator
Differential D6385

Fix: importmulti only imports origin info for PKH outputs
ClosedPublic
Actions

Authored by deadalnix on Jun 5 2020, 16:36.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCa62f3e2135af: Fix: importmulti only imports origin info for PKH outputs
Summary
  • Keep full pubkeys in FlatSigningProvider::origins
  • Import all origin info in importmulti; even for non-importing pubkeys
  • Take non-importing keys into account for spendability warning in descriptor import

This is a backport of Core PR15749

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 5 2020, 16:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2020, 16:36
deadalnix requested review of this revision.Jun 5 2020, 16:36
teamcity edited the summary of this revision. (Show Details)Jun 5 2020, 16:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11226: Diff 20942.Jun 5 2020, 16:47
deadalnix added a child revision: D6387: Batch write imported stuff in importmulti.Jun 5 2020, 17:06
majcosta added a subscriber: majcosta.Jun 5 2020, 17:21
majcosta accepted this revision.Jun 5 2020, 17:25
This revision is now accepted and ready to land.Jun 5 2020, 17:25
Closed by commit rABCa62f3e2135af: Fix: importmulti only imports origin info for PKH outputs (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyJun 5 2020, 17:40
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCa62f3e2135af: Fix: importmulti only imports origin info for PKH outputs.

Revision Contents
Changeset List

PathSize
src/
script/
5 lines
2 lines
7 lines
test/
4 lines
wallet/
15 lines
test/
functional/
3 lines

Diff 20946

View Options

src/script/descriptor.cpp

Loading...
View Options

src/script/sign.h

Loading...
View Options

src/script/sign.cpp

Loading...
View Options

src/test/descriptor_tests.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/wallet_importmulti.py

Loading...