Differential D6392

[backport#15750] [rpc] Remove the addresses field from the getaddressinfo return object
ClosedPublic
Actions

Authored by majcosta on Jun 5 2020, 19:27.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC9d416a843f8c: [backport#15750] [rpc] Remove the addresses field from the getaddressinfo…

Summary

The "addresses" field was confusing because it refered to public keys
using their P2PKH address. It was included in the return object when
needed for backward compatibility. Remove that compatibility now that
the -deprecatedrpc=validateaddress option has been removed.

New applications should use the 'embedded'->'address' field for P2SH or
P2WSH wrapped addresses, and 'pubkeys' for inspecting multisig
participants.

https://github.com/bitcoin/bitcoin/pull/15750/commits/b4338c151d4788c33f4b7c54daaf7f94b193a624

Backport of Core PR15750

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 5 2020, 19:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2020, 19:27

majcosta requested review of this revision.Jun 5 2020, 19:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11234: Diff 20955.Jun 5 2020, 19:37

deadalnix accepted this revision.Jun 5 2020, 20:53

This revision is now accepted and ready to land.Jun 5 2020, 20:53

Closed by commit rABC9d416a843f8c: [backport#15750] [rpc] Remove the addresses field from the getaddressinfo… (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyJun 5 2020, 21:57

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC9d416a843f8c: [backport#15750] [rpc] Remove the addresses field from the getaddressinfo….

Revision Contents
Changeset List

Path

Size

src/

wallet/

20 lines

Diff 20966

src/wallet/rpcwallet.cpp

Loading...