HomePhabricator

[backport#15750] [rpc] Remove the addresses field from the getaddressinfo…

Description

[backport#15750] [rpc] Remove the addresses field from the getaddressinfo return object

Summary:
The "addresses" field was confusing because it refered to public keys
using their P2PKH address. It was included in the return object when
needed for backward compatibility. Remove that compatibility now that
the -deprecatedrpc=validateaddress option has been removed.

New applications should use the 'embedded'->'address' field for P2SH or
P2WSH wrapped addresses, and 'pubkeys' for inspecting multisig
participants.

https://github.com/bitcoin/bitcoin/pull/15750/commits/b4338c151d4788c33f4b7c54daaf7f94b193a624


Backport of Core PR15750

Test Plan:

ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6392

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Apr 4 2019, 20:02
majcostaCommitted on Jun 5 2020, 21:57
majcostaPushed on Jun 5 2020, 21:57
Reviewer
Restricted Project
Differential Revision
D6392: [backport#15750] [rpc] Remove the addresses field from the getaddressinfo return object
Parents
rABC705b3c6c8cca: Merge #15246: qa: Add tests for invalid message headers
Branches
Unknown
Tags
Unknown