Page MenuHomePhabricator
Differential D6396

Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic
ClosedPublic
Actions

Authored by jasonbcox on Jun 5 2020, 21:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC294237a627c8: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic
Summary

faca95effd qa: Make swap_magic_bytes in p2p_invalid_messages atomic (MarcoFalke)

Pull request description:

Otherwise, this will lead to errors logged in the network thread:

https://travis-ci.org/MarcoFalke/bitcoin/jobs/513076282#L2765

ACKs for commit faca95:

Tree-SHA512: 8bc8280f9c0e8d40bc68c0ff1cab1c3386cbfef0728dbab5f29c2606dd65a9ac3c695b0c286be707a9f2bd62a6f87ac2032d7749fc2cf8b9fa1eba3c4cf70933

Backport of Core PR15697

Depends on D6395

Test Plan

test_runner.py p2p_invalid_messages

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 5 2020, 21:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2020, 21:45
jasonbcox requested review of this revision.Jun 5 2020, 21:45
teamcity edited the summary of this revision. (Show Details)Jun 5 2020, 21:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11240: Diff 20965.Jun 5 2020, 22:05
deadalnix accepted this revision.Jun 5 2020, 23:29
This revision is now accepted and ready to land.Jun 5 2020, 23:29
Closed by commit rABC294237a627c8: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJun 8 2020, 16:53
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC294237a627c8: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic.

Revision Contents
Changeset List

PathSize
test/
functional/
20 lines

Diff 21095

View Options

test/functional/p2p_invalid_messages.py

Loading...