Paths

Table of Contentst

Differential D6419

[backport#16839] Avoid using g_rpc_node global in wallet code
ClosedPublic
Actions

Authored by majcosta on Jun 6 2020, 22:01.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC7a4fc02d8de7: [backport#16839] Avoid using g_rpc_node global in wallet code

Summary

Wallet code should use interfaces::Chain and not directly access to node state.

Add a g_rpc_chain replacement global for wallet code to use, and move
g_rpc_node definition to a libbitcoin_server source file so there are link
errors if wallet code tries to access it.

https://github.com/bitcoin/bitcoin/pull/16839/commits/362ded410b8cb1104b7ef31ff8488fec4824a7d5

Depends on D6418

Concludes backport of Core PR16839

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16839

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11268
Build 21311: Default Diff Build & Tests
Build 21310: Build without Wallet
Build 21309: Build with clang-10
Build 21308: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 6 2020, 22:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 22:01

majcosta requested review of this revision.Jun 6 2020, 22:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11268: Diff 21005.Jun 6 2020, 22:14

What about src/rpc/blockchain.h ?

src/interfaces/wallet.cpp
501	Why return? This does nothing, you can remove it.
src/wallet/rpcwallet.cpp
3167	This isn't in the original PR. Can you explain?

This revision now requires changes to proceed.Jun 6 2020, 22:27

rebased onto missing deps, addressed comments

Harbormaster completed remote builds in B11277: Diff 21017.Jun 7 2020, 00:43

deadalnix accepted this revision.Jun 7 2020, 01:07

This revision is now accepted and ready to land.Jun 7 2020, 01:07

Closed by commit rABC7a4fc02d8de7: [backport#16839] Avoid using g_rpc_node global in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyJun 7 2020, 01:51

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC7a4fc02d8de7: [backport#16839] Avoid using g_rpc_node global in wallet code.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

2 lines

rpc/

2 lines

1 line

rawtransaction.cpp

1 line

6 lines

2 lines

test/

1 line

util/

setup_common.cpp

1 line

wallet/

6 lines

10 lines

Diff 21005

src/interfaces/wallet.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/net.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/rpc/util.h

Loading...

src/rpc/util.cpp

Loading...

src/test/rpc_tests.cpp

Loading...

src/test/util/setup_common.cpp

Loading...

src/wallet/rpcwallet.h

Loading...

src/wallet/rpcwallet.cpp

Loading...