Page MenuHomePhabricator
Differential D6486

[backport#16239] wallet/rpc: use static help text
ClosedPublic
Actions

Authored by majcosta on Jun 9 2020, 18:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC14ba6321bfc8: [backport#16239] wallet/rpc: use static help text
Summary

Always show the same help topic regardless of wallet flags, and explain that something is not always available, rather than runtime-modifying the help output.

https://github.com/bitcoin/bitcoin/pull/16239/commits/3d2ff379131a01e4e9f9648b150e806104a23795

Partial backport of Core PR16239

Test Plan
ninja
./src/bitcoind -regtest -daemon
./src/bitcoin-cli -regtest help sendtoaddress
./src/bitcoin-cli -regtest help getbalance
./src/bitcoin-cli -regtest help listunspent

check help output looks spiffy

test_runner.py wallet_avoidreuse

Diff Detail

Event Timeline

majcosta created this revision.Jun 9 2020, 18:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2020, 18:24
majcosta requested review of this revision.Jun 9 2020, 18:24
teamcity edited the summary of this revision. (Show Details)Jun 9 2020, 18:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11363: Diff 21175.Jun 9 2020, 18:57
Fabien edited the summary of this revision. (Show Details)Jun 10 2020, 06:50
Fabien accepted this revision.Jun 10 2020, 06:52
This revision is now accepted and ready to land.Jun 10 2020, 06:52
Closed by commit rABC14ba6321bfc8: [backport#16239] wallet/rpc: use static help text (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by majcosta). · Explain WhyJun 10 2020, 07:02
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC14ba6321bfc8: [backport#16239] wallet/rpc: use static help text.

Revision Contents
Changeset List

PathSize
src/
wallet/
214 lines

Diff 21175

View Options

src/wallet/rpcwallet.cpp

Loading...