Differential D6511

[backport#15305] [validation] Crash if disconnecting a block fails
ClosedPublic
Actions

Authored by majcosta on Jun 10 2020, 21:35.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC993b00906a19: [backport#15305] [validation] Crash if disconnecting a block fails

Summary

a47df13471e3168e2e02023fb20cdf2414141b36 [qa] Test disconnect block failure -> shutdown (Suhas Daftuar)
4433ed0f730cfd60eeba3694ff3c283ce2c0c8ee [validation] Crash if disconnecting a block fails (Suhas Daftuar)

Pull request description:

If we're unable to disconnect a block during normal operation, then that is a
failure of our local system (such as disk failure) or the chain that we are on
(eg CVE-2018-17144), but cannot be due to failure of the (more work) chain that
we're trying to validate.

We should abort rather than stay on a less work chain.

Fixes #14341.

Backport of Core PR15305

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 10 2020, 21:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2020, 21:35

majcosta requested review of this revision.Jun 10 2020, 21:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11399: Diff 21246.Jun 10 2020, 21:50

deadalnix accepted this revision.Jun 10 2020, 21:51

This revision is now accepted and ready to land.Jun 10 2020, 21:51

Closed by commit rABC993b00906a19: [backport#15305] [validation] Crash if disconnecting a block fails (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyJun 10 2020, 22:04

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC993b00906a19: [backport#15305] [validation] Crash if disconnecting a block fails.

Revision Contents
Changeset List

Path

Size

src/

8 lines

test/

functional/

feature_abortnode.py

51 lines

Diff 21249

src/validation.cpp

Loading...

test/functional/feature_abortnode.py

Loading...