Differential D6518

[backport#16117] scripted-diff: Replace MilliSleep with UninterruptibleSleep
ClosedPublic
Actions

Authored by majcosta on Jun 10 2020, 23:49.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC5a8dfec98f61: [backport#16117] scripted-diff: Replace MilliSleep with UninterruptibleSleep

Summary

This is safe because MilliSleep is never executed in a boost::thread,
the only type of thread that is interruptible.

The RPC server uses std::thread
The wallet is either executed in an RPC thread or the main thread
bitcoin-cli, benchmarks and tests are only one thread (the main thread)

-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e
's/MilliSleep$(\S+)$;/UninterruptibleSleep(std::chrono::milliseconds{\1});/g'
$(git grep -l MilliSleep)
-END VERIFY SCRIPT-

https://github.com/bitcoin/bitcoin/pull/16117/commits/fa9af06d91e9357e86863781746f0e78a509967e

Depends on D6517

Partial backport of Core PR16117

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 10 2020, 23:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2020, 23:49

majcosta requested review of this revision.Jun 10 2020, 23:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6519: [backport#16117] util: Remove unused MilliSleep.Jun 10 2020, 23:50

Harbormaster completed remote builds in B11406: Diff 21256.Jun 11 2020, 00:10

deadalnix accepted this revision.Jun 11 2020, 00:16

This revision is now accepted and ready to land.Jun 11 2020, 00:16

Closed by commit rABC5a8dfec98f61: [backport#16117] scripted-diff: Replace MilliSleep with UninterruptibleSleep (authored by majcosta). · Explain WhyJun 11 2020, 00:48

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC5a8dfec98f61: [backport#16117] scripted-diff: Replace MilliSleep with UninterruptibleSleep.

deadalnix mentioned this in D6530: UninterruptibleSleep in avalanche test.Jun 11 2020, 11:11

deadalnix mentioned this in rABC72ebb4217e4f: UninterruptibleSleep in avalanche test.Jun 11 2020, 12:53

Revision Contents
Changeset List

Path

Size

src/

bench/

2 lines

2 lines

2 lines

3 lines

rpc/

server.cpp

3 lines

test/

blockfilter_index_tests.cpp

2 lines

checkqueue_tests.cpp

2 lines

txindex_tests.cpp

2 lines

util_tests.cpp

4 lines

validation_block_tests.cpp

2 lines

wallet/

db.cpp

4 lines

Diff 21261

View Options

src/bench/examples.cpp

View Options

src/bitcoin-cli.cpp

View Options

src/bitcoind.cpp

View Options

src/httprpc.cpp

View Options

src/rpc/server.cpp

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/checkqueue_tests.cpp

View Options

src/test/txindex_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/test/validation_block_tests.cpp

View Options

[backport#16117] scripted-diff: Replace MilliSleep with UninterruptibleSleepClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21261

src/bench/examples.cpp

src/bitcoin-cli.cpp

src/bitcoind.cpp

src/httprpc.cpp

src/rpc/server.cpp

src/test/blockfilter_index_tests.cpp

src/test/checkqueue_tests.cpp

src/test/txindex_tests.cpp

src/test/util_tests.cpp

src/test/validation_block_tests.cpp

src/wallet/db.cpp

[backport#16117] scripted-diff: Replace MilliSleep with UninterruptibleSleep
ClosedPublic
Actions

Revision Contents
Changeset List