Differential D6565

Make CLIENT_VERSION constexpr
ClosedPublic
Actions

Authored by deadalnix on Jun 14 2020, 13:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd2d485e2b1a0: Make CLIENT_VERSION constexpr

Summary

As per title.

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

clientversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11470
Build 22031: Default Diff Build & Tests	Link to the build
Build 22030: Build without Wallet	Link to the build
Build 22029: Build with clang-10	Link to the build
Build 22028: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 14 2020, 13:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2020, 13:40

deadalnix requested review of this revision.Jun 14 2020, 13:40

Harbormaster completed remote builds in B11470: Diff 21365.Jun 14 2020, 13:52

Fabien accepted this revision.Jun 15 2020, 08:31

This revision is now accepted and ready to land.Jun 15 2020, 08:31

Closed by commit rABCd2d485e2b1a0: Make CLIENT_VERSION constexpr (authored by deadalnix). · Explain WhyJun 15 2020, 13:24

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCd2d485e2b1a0: Make CLIENT_VERSION constexpr.

Revision Contents
Changeset List

Path

Size

src/

clientversion.h

6 lines

Diff 21365

View Options

Make CLIENT_VERSION constexprClosedPublicActions