Page MenuHomePhabricator

[backport#17362] test: speed up wallet_avoidreuse, add logging
ClosedPublic

Authored by majcosta on Jun 15 2020, 18:52.

Details

Summary

0e7c90eb37a687158c261ddd1ff9f1028a1e7012 test: speed up wallet_avoidreuse.py (Jon Atack)
6d50b2606ea9249627556051637080c3587b1b04 test: add logging to wallet_avoidreuse.py (Jon Atack)

Pull request description:

Inspired by PRs #17340 and #15881.

- add logging
- pass -whitelist in `set_test_params` to speed up transaction relay

`wallet_avoidreuse.py` is not intended to test P2P transaction relay/timing, so it should be fine to do this here. This reduces test run time variability and speeds up the test by 2-3 times on average.

Test run times in seconds:

- before: 20, 24, 22, 17, 27, 40, 30

- after: 10, 10, 8, 9, 10, 7, 8

Backport of Core PR17362

Test Plan
test_runner.py wallet_avoidreuse

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jun 15 2020, 20:39