HomePhabricator

[backport#17362] test: speed up wallet_avoidreuse, add logging

Description

[backport#17362] test: speed up wallet_avoidreuse, add logging

Summary:
0e7c90eb37a687158c261ddd1ff9f1028a1e7012 test: speed up wallet_avoidreuse.py (Jon Atack)
6d50b2606ea9249627556051637080c3587b1b04 test: add logging to wallet_avoidreuse.py (Jon Atack)

Pull request description:

Inspired by PRs #17340 and #15881.

- add logging
- pass -whitelist in `set_test_params` to speed up transaction relay

`wallet_avoidreuse.py` is not intended to test P2P transaction relay/timing, so it should be fine to do this here. This reduces test run time variability and speeds up the test by 2-3 times on average.

Test run times in seconds:

- before: 20, 24, 22, 17, 27, 40, 30

- after: 10, 10, 8, 9, 10, 7, 8

Backport of Core PR17362

Test Plan:

test_runner.py wallet_avoidreuse

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6588

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Nov 7 2019, 16:34
majcostaCommitted on Jun 15 2020, 21:00
majcostaPushed on Jun 15 2020, 21:00
Reviewer
Restricted Project
Differential Revision
D6588: [backport#17362] test: speed up wallet_avoidreuse, add logging
Parents
rABC2dca88b1aefc: [backport#16917] tests: Move common function assert_approx() into util.py
Branches
Unknown
Tags
Unknown