Page MenuHomePhabricator

[Qt] Fix deprecated QButtonGroup::buttonClicked event
ClosedPublic

Authored by Fabien on Jun 16 2020, 10:25.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCebe9c33ab580: [Qt] Fix deprecated QButtonGroup::buttonClicked event
Summary

This is replaced by QButtonGroup::idClicked since Qt 5.15.

Test Plan

With Qt 5.5.1 and 5.15:

ninja all check

Check the warning is gone.

With Qt 5.15, run bitcoin-qt and check the custom fee feature still
works as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jun 16 2020, 10:25
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/qt/sendcoinsdialog.cpp
201 ↗(On Diff #21455)

Looks like you had to do this a few time. You should consider factoring the pattern if possible.

This revision is now accepted and ready to land.Jun 16 2020, 12:20
src/qt/sendcoinsdialog.cpp
201 ↗(On Diff #21455)

I had another one similar looking, but different enough that it is not really possible to factorize without making it needlessly complex.