Paths

Table of Contentst

Differential D6606

[Qt] Fix deprecated QButtonGroup::buttonClicked event
ClosedPublic
Actions

Authored by Fabien on Jun 16 2020, 10:25.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCebe9c33ab580: [Qt] Fix deprecated QButtonGroup::buttonClicked event

Summary

This is replaced by QButtonGroup::idClicked since Qt 5.15.

Test Plan

With Qt 5.5.1 and 5.15:

ninja all check

Check the warning is gone.

With Qt 5.15, run bitcoin-qt and check the custom fee feature still
works as expected.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

qt_button_clicked

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11522
Build 22221: Default Diff Build & Tests	Link to the build
Build 22220: Build without Wallet	Link to the build
Build 22219: Build with clang-10	Link to the build
Build 22218: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 16 2020, 10:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2020, 10:25

Fabien requested review of this revision.Jun 16 2020, 10:25

Harbormaster completed remote builds in B11522: Diff 21455.Jun 16 2020, 10:39

deadalnix accepted this revision.Jun 16 2020, 12:20

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/qt/sendcoinsdialog.cpp
201	Looks like you had to do this a few time. You should consider factoring the pattern if possible.

This revision is now accepted and ready to land.Jun 16 2020, 12:20

Fabien added inline comments.Jun 16 2020, 13:11

src/qt/sendcoinsdialog.cpp
201	I had another one similar looking, but different enough that it is not really possible to factorize without making it needlessly complex.

Closed by commit rABCebe9c33ab580: [Qt] Fix deprecated QButtonGroup::buttonClicked event (authored by Fabien). · Explain WhyJun 16 2020, 13:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCebe9c33ab580: [Qt] Fix deprecated QButtonGroup::buttonClicked event.

Revision Contents
Changeset List

Path

Size

src/

qt/

sendcoinsdialog.cpp

27 lines

Diff 21455

View Options

src/qt/sendcoinsdialog.cpp

[Qt] Fix deprecated QButtonGroup::buttonClicked eventClosedPublicActions