Page MenuHomePhabricator

[CI] Make the coverage report available to Teamcity
ClosedPublic

Authored by Fabien on Jun 16 2020, 15:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC19e3653189e6: [CI] Make the coverage report available to Teamcity
Summary

This diff creates an archive from the coverage directory that has the
expected format for Teamcity. This should appear as an HTML page in the
build report tab.

Depends on D6607.

Test Plan

Run the CI build-coverage build plan and check the report tab has the
coverage report.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jun 16 2020, 15:58
deadalnix requested changes to this revision.Jun 16 2020, 15:59
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
contrib/teamcity/build-configurations.sh
341 ↗(On Diff #21462)

tar gz would be preferable.

This revision now requires changes to proceed.Jun 16 2020, 15:59
contrib/teamcity/build-configurations.sh
341 ↗(On Diff #21462)

The doc specifically requires a zip. I'll see if this can be changed, the doc is not the best...

Fabien planned changes to this revision.Jun 16 2020, 16:22

Actually the ZIP is the default configuration, hence the doc, but this can be overridden. I'll update this diff.

contrib/teamcity/build-configurations.sh
341 ↗(On Diff #21464)

Note to reviewers: the -- here is to prevent the glob expansion of files starting with a dash, which would be considered as options. Credit to shellcheck.

This revision is now accepted and ready to land.Jun 16 2020, 17:06