Page MenuHomePhabricator
Differential D6662

[backport#14953] test: Make g_insecure_rand_ctx thread_local
AbandonedPublic
Actions

Authored by majcosta on Jun 22 2020, 06:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

faead93c6c test: Make g_insecure_rand_ctx thread_local (MarcoFalke)

Pull request description:

Some tests might spin up several threads and `FastRandomContext` is not thread safe.

Fix that by giving each thread their own randomness context (as opposed to e.g. making `FastRandomContext` thread safe or add locks elsewhere).

Also, add the `g_` prefix to it (according to developer notes), since I am touching it anyway.

https://github.com/bitcoin/bitcoin/pull/14953/commits/faead93c6c7e1d27bd2a1b2a9b496fda838c2996

Backport of Core PR14953

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta created this revision.Jun 22 2020, 06:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2020, 06:07
majcosta requested review of this revision.Jun 22 2020, 06:07
teamcity edited the summary of this revision. (Show Details)Jun 22 2020, 06:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11600: Diff 21585.Jun 22 2020, 06:20
Fabien requested changes to this revision.Jun 22 2020, 07:41
Fabien added a subscriber: Fabien.

NACK, see https://github.com/bitcoin/bitcoin/pull/14985, and also D3485 and D3628.

This revision now requires changes to proceed.Jun 22 2020, 07:41
majcosta added a comment.Jun 22 2020, 07:45
In D6662#162548, @Fabien wrote:

NACK, see https://github.com/bitcoin/bitcoin/pull/14985, and also D3485 and D3628.

oh good, thank you.

majcosta abandoned this revision.Jun 22 2020, 07:46

Revision Contents
Changeset List

PathSize
src/
test/
util/
2 lines
2 lines

Diff 21585

View Options

src/test/util/setup_common.h

Loading...
View Options

src/test/util/setup_common.cpp

Loading...