Page MenuHomePhabricator

[CI] Wrap the build_cmake.sh environment and script path into a function
ClosedPublic

Authored by Fabien on Tue, Jun 23, 13:18.

Details

Summary

This diff improves readability of the build_cmake.sh call by wrapping it
into a function that extend the cmake flags array and hide the path. It
also makes consistent use of newlines and put options in the first
positions to improve readability. This does not change the behavior.

Depends on D6677.

Test Plan

Run any CI build plan that uses the build_with_cmake function.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jun 23, 13:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jun 23, 13:18
Fabien requested review of this revision.Tue, Jun 23, 13:18
deadalnix accepted this revision.Tue, Jun 23, 14:09
This revision is now accepted and ready to land.Tue, Jun 23, 14:09
Fabien updated this revision to Diff 21636.Tue, Jun 23, 14:24

Rebase