Page MenuHomePhabricator

[CI] Make the build_autotools.sh script take a list of targets
ClosedPublic

Authored by Fabien on Tue, Jun 23, 16:12.

Details

Summary

Similar to what the build_cmake.sh script works, arguments passed to
the build_autotools.sh script are a list of targets to build.

Test Plan

Run the CI build-autotools build plan.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jun 23, 16:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jun 23, 16:12
Fabien requested review of this revision.Tue, Jun 23, 16:12
Fabien added a comment.Tue, Jun 23, 16:16

@bot build-autotools

deadalnix accepted this revision.Tue, Jun 23, 16:38
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
contrib/devtools/build_autotools.sh
27 ↗(On Diff #21646)

Should we add all to the list of target for good measure?

This revision is now accepted and ready to land.Tue, Jun 23, 16:38
Fabien added inline comments.Tue, Jun 23, 16:40
contrib/devtools/build_autotools.sh
27 ↗(On Diff #21646)

For some reason this fails the build (at least on my machine), so I left it as is. The check target already builds all anyway so there is no coverage issue introduced here.

This revision was landed with ongoing or failed builds.Tue, Jun 23, 16:41
This revision was automatically updated to reflect the committed changes.