Page MenuHomePhabricator
Differential D6686

[CI] Make the build_autotools.sh script take a list of targets
ClosedPublic
Actions

Authored by Fabien on Jun 23 2020, 16:12.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC4f31ce8a67fa: [CI] Make the build_autotools.sh script take a list of targets
Summary

Similar to what the build_cmake.sh script works, arguments passed to
the build_autotools.sh script are a list of targets to build.

Test Plan

Run the CI build-autotools build plan.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 23 2020, 16:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 23 2020, 16:12
Fabien requested review of this revision.Jun 23 2020, 16:12
Fabien added a comment.Jun 23 2020, 16:16

@bot build-autotools

Fabien added a child revision: D6687: [CI] Wrap the build_autotools.sh script in a function.Jun 23 2020, 16:22
deadalnix accepted this revision.Jun 23 2020, 16:38
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
contrib/devtools/build_autotools.sh
27 ↗(On Diff #21646)

Should we add all to the list of target for good measure?

This revision is now accepted and ready to land.Jun 23 2020, 16:38
Fabien added inline comments.Jun 23 2020, 16:40
contrib/devtools/build_autotools.sh
27 ↗(On Diff #21646)

For some reason this fails the build (at least on my machine), so I left it as is. The check target already builds all anyway so there is no coverage issue introduced here.

This revision was landed with ongoing or failed builds.Jun 23 2020, 16:41
Closed by commit rABC4f31ce8a67fa: [CI] Make the build_autotools.sh script take a list of targets (authored by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4f31ce8a67fa: [CI] Make the build_autotools.sh script take a list of targets.
Harbormaster completed remote builds in B11639: Diff 21646.Jun 23 2020, 16:46

Revision Contents
Changeset List

PathSize
contrib/
devtools/
2 lines
teamcity/
3 lines

Diff 21649

View Options

contrib/devtools/build_autotools.sh

Loading...
View Options

contrib/teamcity/build-configurations.sh

Loading...