Page MenuHomePhabricator
Differential D6696

Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string
ClosedPublic
Actions

Authored by jasonbcox on Jun 24 2020, 00:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC32a6ebf19d61: Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string
Summary

41ff4992e57f8626019c0b2ab3d024db71e4c20f script: fix SCRIPT_ERR_SIG_PUSHONLY error string (Sebastian Falbesoner)

Pull request description:

Fixes #18411, changing the error message from `"Only non-push operators allowed in signatures"` to `"Only push operators allowed in signatures"`.

ACKs for top commit:

laanwj:
  ACK 41ff4992e57f8626019c0b2ab3d024db71e4c20f

Tree-SHA512: 3b75d83e2198d638d599ef6a4a8da986f0158600fe3f89f55b3759554588157acf2b0cba3f6a907164617264e7aee727d6d460b510c8b37ca7728aa79e11ad80

Backport of Core PR18412

Although our error message is functionally correct, this brings us more inline with Core (per feedback from https://github.com/Bitcoin-ABC/bitcoin-abc/issues/393)

Test Plan

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 24 2020, 00:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 00:44
jasonbcox requested review of this revision.Jun 24 2020, 00:44
teamcity edited the summary of this revision. (Show Details)Jun 24 2020, 00:44

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Jun 24 2020, 00:57
This revision is now accepted and ready to land.Jun 24 2020, 00:57
Harbormaster completed remote builds in B11651: Diff 21671.Jun 24 2020, 00:58
Closed by commit rABC32a6ebf19d61: Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJun 24 2020, 16:38
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC32a6ebf19d61: Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string.

Revision Contents
Changeset List

PathSize
src/
script/
2 lines

Diff 21698

View Options

src/script/script_error.cpp

Loading...