Page MenuHomePhabricator

[CI] Convert the build-configurations.sh script to python, read config
ClosedPublic

Authored by Fabien on Jun 24 2020, 18:37.

Details

Summary

This diff converts the build-configurations.sh script to python, and
make it read the build configuration from a json file. For now it is
limited to running the script and forwarding the error code.

This configuration file will later allow to add more features.
The bash script is kept as a dummy wrapper to keep compatibility with
existing infra.

Test Plan

Run any CI build, both with the python and the shell script.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien requested review of this revision.Jun 24 2020, 18:37
Fabien planned changes to this revision.Jun 24 2020, 18:37
jasonbcox requested changes to this revision.Jun 24 2020, 18:52
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/build-configurations.py
17 ↗(On Diff #21708)

This is only run once. Any reason to keep it as its own method?

30 ↗(On Diff #21708)

Nit: than -> as

66 ↗(On Diff #21708)

if not build:
We don't expect args.build or a json key to be empty string, but better safe than sorry.

This revision now requires changes to proceed.Jun 24 2020, 18:52
This revision is now accepted and ready to land.Jun 24 2020, 20:11