Page MenuHomePhabricator

[avalanche] Add test for the parking scenario
ClosedPublic

Authored by deadalnix on Jun 25 2020, 00:50.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC1eea7d56ce99: [avalanche] Add test for the parking scenario
Summary

Now that we poll all blocks, the parking code is reachable and deserve to be tested.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta requested changes to this revision.Jun 25 2020, 06:12
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/abc_p2p_avalanche.py
251 ↗(On Diff #21746)

use generatetoaddress instead

This revision now requires changes to proceed.Jun 25 2020, 06:12
deadalnix added inline comments.
test/functional/abc_p2p_avalanche.py
251 ↗(On Diff #21746)

It does already. That should be obvious from the fact the flags to enable the deprecated RPC are not passed.

This revision is now accepted and ready to land.Jun 25 2020, 23:35