Differential D6758

Remove dead checkpoint test
ClosedPublic
Actions

Authored by deadalnix on Jun 27 2020, 15:26.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCedbca26ce4c2: Remove dead checkpoint test

Summary

This is testing nothing. The checkpoint code is not even reached.

Because the block passed is not the genesis block, the code tries to fetch it's parent, which doesn't exist and as a result we cannot raach the checkpoint related code.

Test Plan

ninja al check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 27 2020, 15:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2020, 15:26

deadalnix requested review of this revision.Jun 27 2020, 15:26

Harbormaster completed remote builds in B11748: Diff 21825.Jun 27 2020, 15:41

Fabien accepted this revision.Jun 27 2020, 16:14

This revision is now accepted and ready to land.Jun 27 2020, 16:14

Closed by commit rABCedbca26ce4c2: Remove dead checkpoint test (authored by deadalnix). · Explain WhyJun 27 2020, 16:18

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCedbca26ce4c2: Remove dead checkpoint test.

Revision Contents
Changeset List

Path

Size

src/

test/

checkpoints_tests.cpp

30 lines

Diff 21826

View Options

src/test/checkpoints_tests.cpp

Remove dead checkpoint testClosedPublicActions