Differential D6772

[avalanche] Introduce a datastructure to keep track of peers
ClosedPublic
Actions

Authored by deadalnix on Jun 29 2020, 20:12.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC1a731a37599a: [avalanche] Introduce a datastructure to keep track of peers

Summary

This implement an utility that can select a peer with a probability depending on its score. The higher the score, the more likely that peer is to be chosen.

Obviously, this is not usable as this because it exposes index from internal datastructures, but this much allows to check the algorithm are correct and constitue a useful unit of work.

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 29 2020, 20:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2020, 20:12

deadalnix requested review of this revision.Jun 29 2020, 20:12

Harbormaster completed remote builds in B11774: Diff 21864.Jun 29 2020, 20:27

deadalnix added a child revision: D6773: [avalanche] Add the ability to remove and rescore peers.Jun 29 2020, 20:38

This change seems fine, but there isn't enough info in the summary to get a good picture for why this particular implementation was selected over other possible implementations. Regardless, it appears to do some job and is tested.

Also, there are many typos or grammar issues in the comments, but I won't block on these.

This revision is now accepted and ready to land.Jun 29 2020, 21:51

Closed by commit rABC1a731a37599a: [avalanche] Introduce a datastructure to keep track of peers (authored by deadalnix). · Explain WhyJun 29 2020, 22:49

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC1a731a37599a: [avalanche] Introduce a datastructure to keep track of peers.