Page MenuHomePhabricator
Differential D6802

[backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet::CreateTransaction
ClosedPublic
Actions

Authored by majcosta on Jul 1 2020, 20:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe942ee183dcb: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet…
Summary

https://github.com/bitcoin/bitcoin/pull/16208/commits/e10e1e8db043e9b7c113e07faf408f337c1b732d

Depends on D6800

Concludes backport of Core PR16028

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 1 2020, 20:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2020, 20:47
majcosta requested review of this revision.Jul 1 2020, 20:47
teamcity edited the summary of this revision. (Show Details)Jul 1 2020, 20:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11814: Diff 21946.Jul 1 2020, 21:02
Fabien accepted this revision.Jul 2 2020, 08:45
This revision is now accepted and ready to land.Jul 2 2020, 08:45
Closed by commit rABCe942ee183dcb: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet… (authored by Gregory Sanders <gsanders87@gmail.com>, committed by majcosta). · Explain WhyJul 2 2020, 14:21
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCe942ee183dcb: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet….

Revision Contents
Changeset List

PathSize
src/
interfaces/
13 lines
wallet/
17 lines
test/
8 lines
11 lines
14 lines

Diff 21956

View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...