Differential D6820

[avalanche] Use constexpr for global constants
ClosedPublic
Actions

Authored by deadalnix on Jul 4 2020, 23:32.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC7bd7f8c0caea: [avalanche] Use constexpr for global constants

Summary

Also remove useless anonymous namespace.

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 4 2020, 23:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2020, 23:32

deadalnix requested review of this revision.Jul 4 2020, 23:32

Also do AVALANCHE_TIME_STEP_MILLISECONDS

Harbormaster completed remote builds in B11849: Diff 21997.Jul 4 2020, 23:48

Harbormaster completed remote builds in B11850: Diff 21998.Jul 4 2020, 23:57

Nit: consider getting rid of the AVALANCHE_ prefix unless where needed to convey that info; this is all static and we're in src/avalanche after all

This revision is now accepted and ready to land.Jul 5 2020, 00:11

Closed by commit rABC7bd7f8c0caea: [avalanche] Use constexpr for global constants (authored by deadalnix). · Explain WhyJul 5 2020, 00:34

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC7bd7f8c0caea: [avalanche] Use constexpr for global constants.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

17 lines

processor.cpp

2 lines

Diff 22002

View Options

src/avalanche/processor.h