Page MenuHomePhabricator
Differential D6825

[avalanche] Add a facility to update node's timeout
ClosedPublic
Actions

Authored by deadalnix on Jul 5 2020, 21:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc357d6422cbd: [avalanche] Add a facility to update node's timeout
Summary

This feature is required as any reply from the node comes with a cooldown time.

Depends on D6824

Test Plan
ninja all check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 5 2020, 21:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2020, 21:59
deadalnix requested review of this revision.Jul 5 2020, 21:59
Harbormaster completed remote builds in B11860: Diff 22011.Jul 5 2020, 22:15
Fabien accepted this revision.Jul 6 2020, 06:32
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/peermanager.cpp
121 ↗(On Diff #22011)

What about making the timeout monotonic ? I don't think there is a valid scenario where it's value should be lowered (or set < now).
It's maybe better suited to the callsite though, where the logic resides.

This revision is now accepted and ready to land.Jul 6 2020, 06:32
deadalnix added inline comments.Jul 6 2020, 12:40
src/avalanche/peermanager.cpp
121 ↗(On Diff #22011)

There is no reason to limit this here.

Closed by commit rABCc357d6422cbd: [avalanche] Add a facility to update node's timeout (authored by deadalnix). · Explain WhyJul 6 2020, 12:41
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc357d6422cbd: [avalanche] Add a facility to update node's timeout.

Revision Contents
Changeset List

PathSize
src/
avalanche/
2 lines
9 lines
test/
38 lines

Diff 22018

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...