Page MenuHomePhabricator

[avalanche] Add a facility to update node's timeout
ClosedPublic

Authored by deadalnix on Jul 5 2020, 21:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc357d6422cbd: [avalanche] Add a facility to update node's timeout
Summary

This feature is required as any reply from the node comes with a cooldown time.

Depends on D6824

Test Plan
ninja all check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/peermanager.cpp
121 ↗(On Diff #22011)

What about making the timeout monotonic ? I don't think there is a valid scenario where it's value should be lowered (or set < now).
It's maybe better suited to the callsite though, where the logic resides.

This revision is now accepted and ready to land.Jul 6 2020, 06:32
src/avalanche/peermanager.cpp
121 ↗(On Diff #22011)

There is no reason to limit this here.