Page MenuHomePhabricator
Differential D6831

[avalanche] Factor AvalancheNode from PeerManager
ClosedPublic
Actions

Authored by deadalnix on Jul 6 2020, 20:49.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC7d1e29374d16: [avalanche] Factor AvalancheNode from PeerManager
Summary

As per title.

Depends on D6830

Test Plan
ninja all check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 6 2020, 20:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 6 2020, 20:49
deadalnix requested review of this revision.Jul 6 2020, 20:49
Harbormaster completed remote builds in B11868: Diff 22027.Jul 6 2020, 21:10
jasonbcox accepted this revision.Jul 6 2020, 21:36
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/avalanche/processor.cpp
342 ↗(On Diff #22027)

score is unused now, and the tests that call addPeer always set this to 0. I assume this will integrate with PeerManager in the near future?

This revision is now accepted and ready to land.Jul 6 2020, 21:36
deadalnix added inline comments.Jul 6 2020, 21:48
src/avalanche/processor.cpp
342 ↗(On Diff #22027)

It never was used.

Closed by commit rABC7d1e29374d16: [avalanche] Factor AvalancheNode from PeerManager (authored by deadalnix). · Explain WhyJul 6 2020, 21:49
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC7d1e29374d16: [avalanche] Factor AvalancheNode from PeerManager.

Revision Contents
Changeset List

PathSize
src/
avalanche/
12 lines
34 lines
5 lines
3 lines

Diff 22034

View Options

src/avalanche/node.h

Loading...
View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/processor.cpp

Loading...