Page MenuHomePhabricator
Differential D6850

[avalanche] Remove PeerManager::addNodeToPeer
ClosedPublic
Actions

Authored by deadalnix on Jul 8 2020, 00:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC216aa09cb42b: [avalanche] Remove PeerManager::addNodeToPeer
Summary

Replace it by a proof based API.

Depends on D6845 and D6848

Test Plan
ninja all check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 8 2020, 00:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2020, 00:16
deadalnix requested review of this revision.Jul 8 2020, 00:16
deadalnix added a child revision: D6851: [avalanche] Kill PeerManager::addPeer.Jul 8 2020, 00:20
Harbormaster completed remote builds in B11894: Diff 22063.Jul 8 2020, 00:32
Fabien requested changes to this revision.Jul 8 2020, 09:23
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/processor.cpp
339 ↗(On Diff #22063)

should be score

340 ↗(On Diff #22063)

Nit: you can return directly

This revision now requires changes to proceed.Jul 8 2020, 09:23
deadalnix updated this revision to Diff 22076.Jul 8 2020, 14:53

Fix Processor::addPeer

Fabien accepted this revision.Jul 8 2020, 14:54
This revision is now accepted and ready to land.Jul 8 2020, 14:54
This revision was landed with ongoing or failed builds.Jul 8 2020, 14:54
Closed by commit rABC216aa09cb42b: [avalanche] Remove PeerManager::addNodeToPeer (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC216aa09cb42b: [avalanche] Remove PeerManager::addNodeToPeer.
Harbormaster completed remote builds in B11900: Diff 22076.Jul 8 2020, 14:56

Revision Contents
Changeset List

PathSize
src/
avalanche/
7 lines
28 lines
2 lines
11 lines
test/
10 lines
8 lines

Diff 22077

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...