Differential D6879

[backport#16887 3/3] test: add unit tests for Span-parsing helpers
ClosedPublic
Actions

Authored by majcosta on Jul 9 2020, 20:09.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC7dab6aa3923c: [backport#16887 3/3] test: add unit tests for Span-parsing helpers

Summary

tests the following four functions:

Const() [parse constant]
Func() [parse function]
Expr() [parse expression]
Split() [split up a string]

https://github.com/bitcoin/bitcoin/pull/16887/commits/bb36372b8f2bd675313ae8553ceb61f28c2c1afd

Depends on D6878

Concludes backport of Core PR16887

Test Plan

ninja check-bitcoin-util_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 9 2020, 20:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 20:09

majcosta requested review of this revision.Jul 9 2020, 20:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6880: [backport#17113] tests: Add fuzzing harness for descriptor Span-parsing helpers.Jul 9 2020, 20:18

Harbormaster completed remote builds in B11934: Diff 22131.Jul 9 2020, 20:31

deadalnix accepted this revision.Jul 9 2020, 22:31

This revision is now accepted and ready to land.Jul 9 2020, 22:31

Closed by commit rABC7dab6aa3923c: [backport#16887 3/3] test: add unit tests for Span-parsing helpers (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by majcosta). · Explain WhyJul 9 2020, 23:37

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC7dab6aa3923c: [backport#16887 3/3] test: add unit tests for Span-parsing helpers.

Revision Contents
Changeset List

Path

Size

src/

test/

123 lines

Diff 22149

src/test/util_tests.cpp

Loading...