This ended up a bit different from Core's for obvious reasons
https://github.com/bitcoin/bitcoin/pull/17357/commits/b7541705d0abfbddf682a0134f3fa8a8e1d06cdf
Depends on D6904
Concludes backport of Core PR17357
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABCbd65ad08d28c: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding
cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ninja bitcoin-fuzzers ./src/test/fuzz/cashaddr
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
| src/test/fuzz/cashaddr.cpp | ||
|---|---|---|
| 36 ↗ | (On Diff #22199) | Unless i don't understand something, I don't think bc is correct here. |
| src/test/fuzz/cashaddr.cpp | ||
|---|---|---|
| 19 ↗ | (On Diff #22212) | I think the : is not expected in the prefix. That should probably fail, because the prefix is expected to be letters only IIRC. Testing for empty prefix would also be beneficial, IMO. |
| src/test/fuzz/cashaddr.cpp | ||
|---|---|---|
| 22 ↗ | (On Diff #22274) | This will always be length 64, no ? It should probably be random length, or there is a whole class of errors that will not show up. |
| src/test/fuzz/cashaddr.cpp | ||
|---|---|---|
| 22 ↗ | (On Diff #22274) | Nono, that returns a string from 0 to 64, randomly |
| src/test/fuzz/cashaddr.cpp | ||
|---|---|---|
| 22 ↗ | (On Diff #22274) | ok. 64 is only 320 bits, no? You might want to bump this to 112 or so so that you can get past the max length. |