Page MenuHomePhabricator
Differential D6914

[avalanche] Add buildavalanchproof RPC call
ClosedPublic
Actions

Authored by deadalnix on Jul 11 2020, 22:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC454b88ccaea6: [avalanche] Add buildavalanchproof RPC call
Summary

As per title. This RPC allow to generate proof from a JSON description of it.

Test Plan
ninja all check-all

The integration test has been updated to use the RPC in question.

Diff Detail

Event Timeline

deadalnix created this revision.Jul 11 2020, 22:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2020, 22:19
deadalnix requested review of this revision.Jul 11 2020, 22:19
Harbormaster completed remote builds in B11980: Diff 22219.Jul 11 2020, 22:31
Fabien requested changes to this revision.Jul 13 2020, 07:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/avalanche.cpp
147

Why ?

168

Nit: since height = 0 is supposed to be the genesis block you can check for height < 1

194

Dito

This revision now requires changes to proceed.Jul 13 2020, 07:44
deadalnix added inline comments.Jul 13 2020, 15:48
src/rpc/avalanche.cpp
147

Leftover debug.

194

dito

deadalnix updated this revision to Diff 22231.Jul 13 2020, 18:14

Address comments

Harbormaster completed remote builds in B11989: Diff 22231.Jul 13 2020, 18:30
Fabien accepted this revision.Jul 13 2020, 18:31
This revision is now accepted and ready to land.Jul 13 2020, 18:31
Closed by commit rABC454b88ccaea6: [avalanche] Add buildavalanchproof RPC call (authored by deadalnix). · Explain WhyJul 13 2020, 19:39
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC454b88ccaea6: [avalanche] Add buildavalanchproof RPC call.

Revision Contents
Changeset List

PathSize
src/
avalanche/
1 line
rpc/
143 lines
1 line
test/
functional/
22 lines

Diff 22219

View Options

src/avalanche/proof.h

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

test/functional/abc_p2p_avalanche.py

Loading...