Page MenuHomePhabricator
Differential D692

Change UpdateTime so it takes a Config paramater instead of the Consensus::Params it used to.
ClosedPublic
Actions

Authored by deadalnix on Nov 15 2017, 17:30.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGb72cdeed86a7: Change UpdateTime so it takes a Config paramater instead of the Consensus…
rABCb72cdeed86a7: Change UpdateTime so it takes a Config paramater instead of the Consensus…
Summary

This will allow to pass the config down to the stack that conmpute difficulty.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
minerupdatetime
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1131
Build 1131: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 15 2017, 17:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2017, 17:30
Harbormaster completed remote builds in B1131: Diff 1756.Nov 15 2017, 17:30
schancel requested changes to this revision.Nov 16 2017, 01:15
schancel added inline comments.
src/miner.h
220

Again, not understanding what should be configurable in here.

This revision now requires changes to proceed.Nov 16 2017, 01:15
deadalnix added inline comments.Nov 16 2017, 01:26
src/miner.h
220

The PoW requirement so we can test PoW changes. Last time there was some global parameter flag read in there, this is bad.

deadalnix requested review of this revision.Nov 16 2017, 01:27
schancel accepted this revision.Nov 16 2017, 16:25
This revision is now accepted and ready to land.Nov 16 2017, 16:25
Closed by commit rABCb72cdeed86a7: Change UpdateTime so it takes a Config paramater instead of the Consensus… (authored by deadalnix). · Explain WhyNov 16 2017, 22:34
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
8 lines
rpc/
2 lines

Diff 1756

View Options

src/miner.h

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...