Merge #17746: refactor: rpc: Remove vector copy from listtransactions
ClosedPublic
Actions

Authored by jasonbcox on Jul 14 2020, 18:06.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC848640a7a499: Merge #17746: refactor: rpc: Remove vector copy from listtransactions

Summary

25bc17fceb08ee9625c5e09e2579117ec6f7a1c5 refactor: rpc: Remove vector copy from listtransactions (João Barbosa)

Pull request description:

Current approach
 - copy accumulated `ret` vector to `arrTmp`
 - drop unnecessary elements from `arrTmp`
 - reverse `arrTmp`
 - clear `ret`
 - copy `arrTmp` to the `ret`

New approach
 - create a vector from the accumulated `ret` with just the necessary elements already reversed
 - copy it to the result

This PR doesn't change behavior.

ACKs for top commit:

ryanofsky:
  Code review ACK 25bc17fceb08ee9625c5e09e2579117ec6f7a1c5. Just comment and commit message tweaks since last review

Tree-SHA512: 87906561e3accdbdb0f4a8194cbcd76ea53ae53d0ce135b90bc54a5f77e300b14ef08505e7daf1fe52426f135442a743da5a027416a769bd454922357cebe7c0

Backport of Core PR17746

This also fixes the linter complaining about potential use-after-erase on the first iterator.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 14 2020, 18:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2020, 18:06

jasonbcox requested review of this revision.Jul 14 2020, 18:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox added a child revision: D6860: Merge #15921: validation: Tidy up ValidationState interface.Jul 14 2020, 18:09

Harbormaster completed remote builds in B12003: Diff 22259.Jul 14 2020, 18:24

majcosta accepted this revision.Jul 14 2020, 20:10

This revision is now accepted and ready to land.Jul 14 2020, 20:10

Closed by commit rABC848640a7a499: Merge #17746: refactor: rpc: Remove vector copy from listtransactions (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by jasonbcox). · Explain WhyJul 14 2020, 20:45

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC848640a7a499: Merge #17746: refactor: rpc: Remove vector copy from listtransactions.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

25 lines

Diff 22262

View Options

Merge #17746: refactor: rpc: Remove vector copy from listtransactionsClosedPublicActions