Page MenuHomePhabricator
Differential D6954

Merge #16302: test: Add missing syncwithvalidationinterfacequeue to wallet_balance test
ClosedPublic
Actions

Authored by jasonbcox on Jul 16 2020, 20:08.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC7a820a75ecfb: Merge #16302: test: Add missing syncwithvalidationinterfacequeue to…
Summary

fa815255c70d32809aac640db4a8762c7d71e8db test: Add missing sync_all to wallet_balance test (MarcoFalke)

Pull request description:

A `syncwithvalidationinterfacequeue` should be sufficient.

Fixes  #16020

ACKs for top commit:

promag:
  ACK fa81525. This can be tested by adding sleep in `CWallet::BlockConnected` just before `LOCK(cs_wallet)` - master will always fail while this PR will succeed.

Tree-SHA512: 07e067c698627f90f0b9848f921b7067adc70c27105db3258e056384197e50dbee055c87839d238cc11bde11179d3f5879b39e1c8e15465f8f07558c694b677d

Backport of Core PR16302

Test Plan

test_runner.py wallet_balance

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 16 2020, 20:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2020, 20:08
jasonbcox requested review of this revision.Jul 16 2020, 20:08
teamcity edited the summary of this revision. (Show Details)Jul 16 2020, 20:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12032: Diff 22313.Jul 16 2020, 20:19
majcosta accepted this revision.Jul 16 2020, 20:47
This revision is now accepted and ready to land.Jul 16 2020, 20:47
Closed by commit rABC7a820a75ecfb: Merge #16302: test: Add missing syncwithvalidationinterfacequeue to… (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJul 16 2020, 22:09
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC7a820a75ecfb: Merge #16302: test: Add missing syncwithvalidationinterfacequeue to….
PiRK added a reverting change: D10895: test: Remove or explain syncwithvalidationinterfacequeue.Jan 25 2022, 16:31
PiRK added a reverting change: rABCc6dea51b697d: test: Remove or explain syncwithvalidationinterfacequeue.Jan 26 2022, 07:25

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines

Diff 22323

View Options

test/functional/wallet_balance.py

Loading...