Fix providing an explicit branch/ref to land-via-bot
ClosedPublic
Actions

Authored by jasonbcox on Jul 17 2020, 21:29.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCb56f68112d84: Fix providing an explicit branch/ref to land-via-bot

Summary

The wildcard argument gives an array, not one object.

Test Plan

Pre-patch, this gives a backtrace:
arc land-via-bot master --hold
Post-patch, this correctly identifies the branch and associated revision:

arc patch <this-patch>
arc land-via-bot HEAD --hold

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 17 2020, 21:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2020, 21:29

jasonbcox requested review of this revision.Jul 17 2020, 21:29

jasonbcox planned changes to this revision.

Harbormaster completed remote builds in B12054: Diff 22348.Jul 17 2020, 21:29

jasonbcox requested review of this revision.Jul 17 2020, 21:30

majcosta accepted this revision.Jul 17 2020, 21:32

This revision is now accepted and ready to land.Jul 17 2020, 21:32

Closed by commit rABCb56f68112d84: Fix providing an explicit branch/ref to land-via-bot (authored by jasonbcox). · Explain WhyJul 17 2020, 23:09

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCb56f68112d84: Fix providing an explicit branch/ref to land-via-bot.

Revision Contents
Changeset List

Path

Size

arcanist/

workflow/

ArcanistLandBotWorkflow.php

4 lines

Diff 22351

View Options

arcanist/workflow/ArcanistLandBotWorkflow.php

Fix providing an explicit branch/ref to land-via-botClosedPublicActions