Renaming bswap_tests test case so that the name does not collide with the test suite name
ClosedPublic
Actions

Authored by jasonbcox on Jul 20 2020, 20:59.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC3af9381d5433: Renaming bswap_tests test case so that the name does not collide with the test…

Summary

This is the only test where the suite and test names are the same. It results in
strange <no class> output in the Teamcity UI: https://build.bitcoinabc.org/viewLog.html?currentGroup=class&scope=Bitcoin_ABC_unit_tests%23teamcity%23*%23teamcity%23*&pager.currentPage=1&order=NAME_ASC&recordsPerPage=20&filterText=&status=&buildTypeId=BitcoinABCMasterLinux&buildId=29086&tab=testsInfo

Test Plan

Check that CI shows bswap_tests class name correctly with this patch

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 20 2020, 20:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2020, 20:59

jasonbcox requested review of this revision.Jul 20 2020, 20:59

jasonbcox planned changes to this revision.

jasonbcox requested review of this revision.Jul 20 2020, 21:07

Harbormaster completed remote builds in B12072: Diff 22375.Jul 20 2020, 21:14

There should be a linter for that

This revision is now accepted and ready to land.Jul 20 2020, 22:35

Closed by commit rABC3af9381d5433: Renaming bswap_tests test case so that the name does not collide with the test… (authored by jasonbcox). · Explain WhyJul 21 2020, 02:33

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC3af9381d5433: Renaming bswap_tests test case so that the name does not collide with the test….

Revision Contents
Changeset List

Path

Size

src/

test/

bswap_tests.cpp

2 lines

Diff 22391

View Options

Renaming bswap_tests test case so that the name does not collide with the test suite nameClosedPublicActions