Differential D6992

[LINTER] Fix syntax error in the cppcheck linter
ClosedPublic
Actions

Authored by Fabien on Jul 21 2020, 18:27.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC32024ec84d3a: [LINTER] Fix syntax error in the cppcheck linter

Summary

Interestingly this extra comma is not failing on most platforms with
recent php, but it fails on Ubuntu Bionic (with PHP 7.2) at least.

Test Plan

On Ubuntu Bionic:

arc lint

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_cppcheck_linter

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12089
Build 24144: Default Diff Build & Tests	build-diff
Build 24143: Build without Wallet	build-without-wallet
Build 24142: Build with clang-10	build-clang-10
Build 24141: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 21 2020, 18:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2020, 18:27

Fabien requested review of this revision.Jul 21 2020, 18:27

Harbormaster completed remote builds in B12089: Diff 22404.Jul 21 2020, 18:38

majcosta accepted this revision.Jul 21 2020, 19:36

This revision is now accepted and ready to land.Jul 21 2020, 19:36

Closed by commit rABC32024ec84d3a: [LINTER] Fix syntax error in the cppcheck linter (authored by Fabien). · Explain WhyJul 21 2020, 20:07

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC32024ec84d3a: [LINTER] Fix syntax error in the cppcheck linter.

Revision Contents
Changeset List

Path

Size

arcanist/

linter/

CppCheckLinter.php

2 lines

Diff 22404

View Options

arcanist/linter/CppCheckLinter.php

[LINTER] Fix syntax error in the cppcheck linterClosedPublicActions