Page MenuHomePhabricator
Differential D7003

Remove the rule that prevent retargeting on regtest from the EDA
ClosedPublic
Actions

Authored by deadalnix on Jul 22 2020, 14:56.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC0054f67328c0: Remove the rule that prevent retargeting on regtest from the EDA
Summary

It is effectively unreachable code because this check is already perfomed in pow.cpp

Test Plan
ninja check-pow

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 22 2020, 14:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2020, 14:56
deadalnix requested review of this revision.Jul 22 2020, 14:56
Harbormaster completed remote builds in B12103: Diff 22423.Jul 22 2020, 15:23
majcosta requested changes to this revision.Jul 23 2020, 01:54
majcosta added a subscriber: majcosta.

Remove the rule that prevent retargeting on regtest*

This revision now requires changes to proceed.Jul 23 2020, 01:54
deadalnix requested review of this revision.Jul 23 2020, 11:24
deadalnix retitled this revision from Remove the rule that prevent retargeting on testnet from the EDA to Remove the rule that prevent retargeting on regtest from the EDA.
deadalnix updated this revision to Diff 22456.Jul 23 2020, 11:39

rebase

Harbormaster completed remote builds in B12131: Diff 22456.Jul 23 2020, 11:56
majcosta accepted this revision.Jul 23 2020, 14:45
This revision is now accepted and ready to land.Jul 23 2020, 14:45
Closed by commit rABC0054f67328c0: Remove the rule that prevent retargeting on regtest from the EDA (authored by deadalnix). · Explain WhyJul 23 2020, 15:18
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC0054f67328c0: Remove the rule that prevent retargeting on regtest from the EDA.

Revision Contents
Changeset List

PathSize
src/
pow/
4 lines

Diff 22468

View Options

src/pow/eda.cpp

Loading...