Page MenuHomePhabricator

Remove the rule that prevent retargeting on regtest from the EDA
ClosedPublic

Authored by deadalnix on Wed, Jul 22, 14:56.

Details

Summary

It is effectively unreachable code because this check is already perfomed in pow.cpp

Test Plan
ninja check-pow

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, Jul 22, 14:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jul 22, 14:56
deadalnix requested review of this revision.Wed, Jul 22, 14:56
majcosta requested changes to this revision.Thu, Jul 23, 01:54
majcosta added a subscriber: majcosta.

Remove the rule that prevent retargeting on regtest*

This revision now requires changes to proceed.Thu, Jul 23, 01:54
deadalnix requested review of this revision.Thu, Jul 23, 11:24
deadalnix retitled this revision from Remove the rule that prevent retargeting on testnet from the EDA to Remove the rule that prevent retargeting on regtest from the EDA.
majcosta accepted this revision.Thu, Jul 23, 14:45
This revision is now accepted and ready to land.Thu, Jul 23, 14:45