Differential D7026

[backport#13657] wallet: assert to ensure accuracy of CMerkleTx::GetBlocksToMaturity
ClosedPublic
Actions

Authored by majcosta on Jul 24 2020, 02:59.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC41089c35ccd8: [backport#13657] wallet: assert to ensure accuracy of CMerkleTx…

Summary

93de2891fa9cb8314573ba3a6ab764bc9c52444d wallet: assert to ensure accuracy of CMerkleTx::GetBlocksToMaturity (Ben Woosley)

Pull request description:

According to my understanding, it should not be possible for coinbase
transactions to be conflicting, thus it should not be possible for
GetDepthInMainChain to return a negative result. If it did, this would
also result in innacurate results for GetBlocksToMaturity due to the
math therein. asserting ensures accuracy.

https://github.com/bitcoin/bitcoin/pull/13657/commits/93de2891fa9cb8314573ba3a6ab764bc9c52444d

Backport of Core PR13657

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 24 2020, 02:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2020, 02:59

majcosta requested review of this revision.Jul 24 2020, 02:59

Harbormaster completed remote builds in B12139: Diff 22480.Jul 24 2020, 03:10

Fabien accepted this revision.Jul 24 2020, 12:42

This revision is now accepted and ready to land.Jul 24 2020, 12:42

Closed by commit rABC41089c35ccd8: [backport#13657] wallet: assert to ensure accuracy of CMerkleTx… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyJul 24 2020, 13:34

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC41089c35ccd8: [backport#13657] wallet: assert to ensure accuracy of CMerkleTx….

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

Path

Size

src/

wallet/

6 lines

Diff 22486

src/wallet/wallet.cpp

Loading...