Page MenuHomePhabricator
Differential D7027

[backport#14138] wallet: Set encrypted_batch to nullptr after delete. Avoid double free in the case of NDEBUG.
ClosedPublic
Actions

Authored by majcosta on Jul 24 2020, 03:22.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC83196514974f: [backport#14138] wallet: Set encrypted_batch to nullptr after delete. Avoid…
Summary

fa462b365715928d2c6eb52ca6a448f367084f0f wallet: Set encrypted_batch to nullptr after delete. Avoid double free in the case of NDEBUG. (practicalswift)

Pull request description:

Set `encrypted_batch` to `nullptr` after delete. Avoid double free in the case of `NDEBUG`.

https://github.com/bitcoin/bitcoin/pull/14138/commits/fa462b365715928d2c6eb52ca6a448f367084f0f

Backport of Core PR14138

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 24 2020, 03:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2020, 03:22
majcosta requested review of this revision.Jul 24 2020, 03:22
Harbormaster completed remote builds in B12140: Diff 22481.Jul 24 2020, 03:38
Fabien accepted this revision.Jul 24 2020, 12:43
This revision is now accepted and ready to land.Jul 24 2020, 12:43
Closed by commit rABC83196514974f: [backport#14138] wallet: Set encrypted_batch to nullptr after delete. Avoid… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyJul 24 2020, 13:38
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC83196514974f: [backport#14138] wallet: Set encrypted_batch to nullptr after delete. Avoid….
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines

Diff 22487

View Options

src/wallet/wallet.cpp

Loading...