Page MenuHomePhabricator

[backport#15491] wallet: Improve log output for errors during load
ClosedPublic

Authored by majcosta on Fri, Jul 24, 03:37.

Details

Summary

faf369880 wallet: Improve log output for errors during load (Glenn Willen)

Pull request description:

When loading the wallet, display the entire path in error messages, instead of
the name (which, for the default wallet, is the empty string.)

When an exception occurs during wallet loading, display e.what() if possible,
instead of nothing.

https://github.com/bitcoin/bitcoin/pull/15491/commits/faf369880822188f2738c6f046d9ef14c9585713


Backport of Core PR15491

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Fri, Jul 24, 03:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jul 24, 03:37
majcosta requested review of this revision.Fri, Jul 24, 03:37
Fabien accepted this revision.Fri, Jul 24, 12:45
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/db.h
107 ↗(On Diff #22482)

Layout

This revision is now accepted and ready to land.Fri, Jul 24, 12:45
teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 22:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.